How/where do you think your code handles the case of missing data?

I suggest that you add print statements to every line to see where your program progresses.

Especially add print statements to the cases where valid data is found and where missing data is handled:

...
if (defined  ($eSheet->{Cells}[$row][0] ))
{
    $master_key=($eSheet->{Cells}[$row][0]->Value);
    $r=$row;
    print "Found (new) master key '$master_key' in row $r\n";
}
else
{
    $master_key=$master_key;
    print "No (new) master key found in row $row, keeping current mast
+er key '$master_key' from row $r\n";
}
...
if (defined $eSheet->{Cells}[$row][$col])
{

 $val=($eSheet->{Cells}[$row][$col]->Value);
 print "Found valid value for '$key' in ($row,$col): '$val'\n";

}
else 
{

 $val=$eSheet->{Cells}[$r][$col]->Value;
 print "Found invalid/empty value for '$key' in ($row,$col), reusing t
+he value from ($r,$col): '$val'\n";

}

[download]

Also, your code would greatly benefit from indenting every line by four spacess for every level of nesting. This makes it much easier for you and others to recognize the structure. Instead of

foreach $row( 1 .. $eSheet->{MaxRow} )
{
if (defined  ($eSheet->{Cells}[$row][0] ))
{
$master_key=($eSheet->{Cells}[$row][0]->Value);
$r=$row;
}
else
{
$master_key=$master_key;
}
...

[download]

write the code as

foreach $row( 1 .. $eSheet->{MaxRow} )
{
    if (defined  ($eSheet->{Cells}[$row][0] ))
    {
        $master_key=($eSheet->{Cells}[$row][0]->Value);
        $r=$row;
    }
    else
    {
        $master_key=$master_key;
    }

[download]

Also see perlstyle and perltidy.

In reply to Re^13: Converting Excel to Hash by Corion
in thread Converting Excel to Hash by ravi179

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.