Hi predrag, Welcome to the Monastery!

There's nothing wrong with your code per se, but it seems like you could combine the last and the first conditionals into another if ... else. ( On the other hand, as soon as you have an if/else like that, you might want to start using a hash lookup or dispatch table instead. )

( edit: The most important thing is clarity and maintainability ... write code that you can understand "at-a-glance" when you come back to it after a couple of months. As you become more fluent in Perl, your code will become more succinct, but there's nothing wrong with being very explicit. )

Hope this helps!


The way forward always starts with a minimal test.

In reply to Re: Begginer's question: If loops one after the other. Is that code correct? by 1nickt
in thread Begginer's question: If loops one after the other. Is that code correct? by predrag

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.