"as a second afterthought, my ($cgi, $CMD) = shift; looks strange. i would have used my ($cgi, $CMD) = @_; instead" Re^2: replace use HTTP::Lite to run a perl file that was on another server

#!/usr/bin/perl -w my $all=get_response('a','b'); sub get_response { my ($cgi, $CMD) = shift; print 'a'.$cgi."\n"; print 'b'.$CMD."\n"; }
Result:
aa Use of uninitialized value $CMD in concatenation (.) or string at x118 +2315.pl line 6. b

is now in the same cgi-bin directorty as the perl script that is calling for that script. replace use HTTP::Lite to run a perl file that was on another server Taking that to mean that the caller was cgi as well i added as an afterthought, that &get_response clobbers %ENV, so you might want to add local %ENV=%ENV; as the first line in sub get_response Re^2: replace use HTTP::Lite to run a perl file that was on another server because i didnt want a clobbered %ENV to mess up some other part of the cgi script.

so probably best is

sub get_response { local %ENV=%ENV; my ($cgi, $query) = @_; ## prepare proper (CGI) environment $ENV{QUERY_STRING} = $query; $ENV{REQUEST_METHOD} = 'GET'; $ENV{GATEWAY_INTERFACE} = 'CGI/1.1'; # add more as needed open(CGI, '-|', $cgi) or die "Can't exec $cgi, $!"; local $/ = undef; my $res = <CGI>; close(CGI) or die "Error running $cgi, $!"; return $res; }
Tho in this case the 3 arg open didnt mean as much since we know that the $cgi parm had no special characters being hardcoded.

well at least my first post had added Using get_response from that node and untested and i did look over the code again and again to make sure it was doing what i thought it was and posted addendums to correct what i thought were weaknesses.


In reply to Re^5: replace use HTTP::Lite to run a perl file that was on another server by huck
in thread replace use HTTP::Lite to run a perl file that was on another server by bNathan

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.