A & B & D - see perlretut. Expand the addr regex to include more than just digits

if (/($re).*addr = ([.\da-fA-F:]+)/){

and the other to include all character up to a comma

while (/($re)[ =]*([^,]+)/g){

C & E- Standardize your keywords to a single space private_uid = and process the input lines to collapse multiple spaces down to one

 s/ +/ /g;    # remove multiple spaces

I suspect as a result of expanding the value regex you will capture things you then want to exclude. I have added a basic cleanup sub for you to expand as required. Full changes are

for my $file (@files){
  my $line_no = 0;
  print "Reading $file\n";
  open my $fh, '<', $file or die $!;
  while (<$fh>){
    chomp;
    ++$line_no;
    s/ +/ /g;    # remove multiple spaces
    
    # special pcscf_v4 extract addr
    if (/($re).*addr = ([.\da-fA-F:]+)/){
      my $msg = update_sheet($1,$2,$_);
      print "Line $line_no $msg special\n"; 
      next;
    }
    
    # match more than 1 per line e.g. usim and isim   
    while (/($re)[ =]*([^,]+)/g){
      my $msg = update_sheet($1,$2,$_);
      print "Line $line_no $msg\n"; 
    }
    
  }  
  close $fh;
}

# update sheet
sub update_sheet {
  my ($kw,$value,$comment) = @_;  
  my $clean = cleanup($kw,$value);
  
  my ($sht,$r,$c) = @{$kwhashref->{$kw}}[0..2];
  my $sel = $Book->Worksheets($sht)->Cells($r,$c+1);
  $sel->Insert({ Shift => -4161}); # xlToRight
  $sel->{Value} = $clean;
  $sel->AddComment( { Text=> $comment } );
  $sel->Comment->Shape->TextFrame->{ AutoSize } = 1;

  $kwhashref->{$kw}[3] = $value; # for debugging
  $kwhashref->{$kw}[4] = $clean; # for debugging
  return "kw=[$kw] value=[$value] clean=[$clean]";
}

# remove unwanted chars from value
sub cleanup {
  my ($kw,$value) = @_;
  
  # generic cleansing
  $value =~ s/[\[\]]//g; # remove all [] brackets
  $value =~ s/^\s+//g;   # remove leading whitespace
  $value =~ s/\s+$//g;   # remove trailing whitespace
  
  # specific cleansing
  #if ($kw =~ //){
    # $value =~ s///g
  #}
  
  return $value;
}

[download]
poj

In reply to Re^14: How to read the value of a variable (read from a Excel file converted Into text file) and put then back into Excel column by poj
in thread How to read the value of a variable (read from a Excel file converted Into text file) and put then back into Excel column by rockyurock

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.