Is there a better way to do this, or one that is more easily understood?

A better and more easily understood (and maintained) way would probably be with a templating module as AnonyMonk has suggested. If you're willing to put all the translation strings into a single hash and pass it around by reference (and you're into masochism), maybe something like: 

c:\@Work\Perl\monks>perl -wMstrict -le
"my %Xlate = (
   foo => { qw(one UNO  two DOS) },
   bar => { qw(fee fie  zit zot) },
   quux => 'hi there',
   );
 ;;
 sub expand {
   my ($str, $hr_xlt) = @_;
   ;;
   my $k = qr{ \w+ }xms;
   my $v = qr{ -> [{] \w+ [}] }xms;
   ;;
   $str =~ s{ (\$) ($k) ($v?) }{ qq{\$hr_xlt->{$2}$3} }xmseeg;
   return $str;
   }
 ;;
 my $s = 't$foo->{one}u $bar->{zit} v $quux w';
 print qq{'$s'};
 ;;
 $s = expand($s, \%Xlate);
 print qq{'$s'};
"
't$foo->{one}u $bar->{zit} v $quux w'
'tUNOu zot v hi there w'

[download]
(Note this doesn't work if the string is '$quuxw'; more delimitation needed.)

Give a man a fish:  <%-{-{-{-<

In reply to Re: Deduplicating a substitution that expands variables by AnomalousMonk
in thread Deduplicating a substitution that expands variables by raysatiro

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.