This logic looks odd because if $FileExt is '.pdf' then it's length (4) will always be greater than 3
if ($FileExt eq ".pdf"){
if (length($FileExt) > 3){
You haven't shown the whole code but it may help you to reduce the levels of ifs with some early next statements like this ;
while (my $filename = readdir(DIR)){
next unless (-f $filename);
next if ($filename eq $SumRptNam);
if ($filename =~ /\.(pdf|xlsx)$/){
my $FileExt = $1;
if ($FileExt eq 'pdf'){
# do X to pdf
}
if ($FileExt eq 'xlsx'){
# do Y to xlxs
}
# do Z to both
}
}
edit : quotes removed from '$SumRptNam'
poj
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.