I'm using qx to ssh several admin commands on remote servers. I know I should be using Net::SSH, but the machines involved are legacy. And by legacy, I mean so ancient that we can't install, update, or patch either the OS or anything else.

I really appreciate any time you can spare to sanity check this script. It's currently running and getting the job done, but if you could let me know if I'm doing anything dangerous or if there's a better and/or more stable way of doing it, that would be wonderful. 

#!/usr/bin/perl
use strict;
use warnings;

use Data::Dumper;
use File::Basename qw(basename);
#use Net::OpenSSH;

sub ops_do_ssh_qx {
   my ($cmd) = @_;

   $cmd->{ssh_cmd} = 'ssh ' .  $cmd->{user} . '\@' . $cmd->{host} . ' 
+\'' . $cmd->{command} . '\'' . ' 2>/dev/null';

   $cmd->{output} = qx($cmd->{ssh_cmd});
   if ( defined $cmd->{output} ) {
      $cmd->{cmd_ret_code} = $?;
      chomp $cmd->{output};
   }
   else {
      ($cmd->{ssh_ret_code}, $cmd->{ssh_ret_msg}) = (0 + $!, '' . $!);
   }

   return $cmd;
}

my $state = {
   progname => basename($0),
   status => 'success'
};

my @commands = (
   { name => 'command_name1',
     user => 'user1',
     host => 'server1.foo.com',
     command => 'rsync_command yadda yadda'
   },
   { name => 'command_name2',
     user => 'user2',
     host => 'server2.foo.com',
     command => 'rsync_command yadda yadda'
   }
);

for my $cmd (@commands) {
   if ($state->{status} eq 'success') {
      my $cmd_status = ops_do_ssh_qx($cmd);
      if ( (!defined $cmd_status->{cmd_ret_code}) or ($cmd_status->{cm
+d_ret_code} != 0) ) {
         $state->{status} = 'failure';
         $state->{stack_trace} = $cmd_status;
      }
   }
}

if ($state->{status} ne 'success') {
   $Data::Dumper::Varname = $state->{progname} . '_state_';
   print Dumper($state);
   exit 1;
}

[download]

Thanks,
cbeckley

Update: I meant Net::OpenSSH rather than Net::SSH

In reply to SSH and qx by cbeckley

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.