Firstly, it looks like you have a typo in the "unless" line, $k should perhaps be $key.

Secondly, using a scalar and concatenating spaces and bad keys onto a string seems a little awkward. Using an array instead and taking advantage of how it is interpolated inside double quotes seems more natural. I'm not sure why you use a mixture of single and double quotes along with concatenation in your print statement, just interpolate inside double quotes.

use strict;
use warnings;

use feature qw{ say };

my %allowed = map { $_ => 1 } qw{ name user host command };

my @commands = (
   {
      name    => q{Fred Bloggs},
      user    => q{fbloggs},
      host    => q{red},
      command => q{ls},,
   },
   {
      name     => q{Charlie Farley},
      user     => q{cfarley},
      host     => q{green},
      zone     => q{A},
      building => q{Chaucer},
      command  => q{ps},
   },
   );

for my $command ( @commands )
{
    my @badKeys = grep { not exists $allowed{ $_ } } keys %$command;
    say
       @badKeys
       ? qq{Command invalid: bad keys: @badKeys}
       :  q{Command OK};
}

[download]

The output.

Command OK
Command invalid: bad keys: zone building

[download]

I hope this is of interest.

Cheers,

JohnGG

In reply to Re^2: How best to validate the keys of hashref arguments? by johngg
in thread How best to validate the keys of hashref arguments? by cbeckley

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.