As you are asking some sensible questions here about your code, I imagine that somebody is prompting you about your code. I think this is your employer or your teacher, so the best approach to proceed would be to ask them about guidance and to follow their guidance. If they recommend a book or course material, you should read that material and (re)do all the exercises yourself.

If you get no guidance from them, please follow the guidance you receive here. Please tell us your situation, so we can provide advice appropriate for your level of learning.

I think that you should read perlsub to learn about subroutine parameters.

The traditional approach would be to pass the connection parameters to your subroutine instead of hardcoding them.

Also, you might want to re-read what the return statement does in perlsyn.

A good introduction to Perl is Modern Perl, which is available online for free. Subroutine parameters are explained here and here.

For example, you could call connect with parameters:

connect( $database, $user, $password );

[download]

That means you need to receive the parameters in the subroutine:

sub connect {
    my( $db, $user, $pw ) = @_;
...
};

[download]

In reply to Re: How to connect multiple databases with single sub routine connection using perl? by Corion
in thread How to connect multiple databases with single sub routine connection using perl? by finddata

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.