So I've got a config file, with something like this in it:

ip_address: 10.0.1.17
user: me

[download]

Config file is used by a Server object:

package Server;

use Carp;
use Moose;
use Modern::Perl;
use Config::Simple;

has 'cfg' => (is => 'ro', isa => 'HashRef', required => 1, writer => '
+_set_cfg' );

sub get {
  validate_pos( @_, {isa => 'Server', optional => 0},{type => SCALAR, 
+optional => 0} );
  my $self = shift;
  my $key = shift;
  my $properties = $self->cfg;
  return $properties->{$key};
}

around BUILDARGS => sub {
  # Load cfg file and set cfg attribute here
}

[download]

So I create a Server object and access the cfg file values like so:

my $server = Server->new('config_file_name');
$server->get('ip_address');

[download]

This all works, but I want to get some practice doing some more advanced stuff with Moose. So I added use MooseX::SingletonMethod and the following BUILD method:

sub BUILD {
  my $self = shift;
  my $properties = $self->cfg;
  foreach my $prop (keys %$properties) {
    # check that the property doesn't already exist as a method
    croak "Server config file property '$prop' clashes with existing m
+ethod. Aborting." 
      if ($self->can($prop));
    # create new method
    $self->add_singleton_method( $prop => sub { $properties->{$prop}; 
+} );
  }
}

[download]

Now I can get the ip address with $server->ip_address. Cool. But I'm wondering if there might be some unintended consequences of something like this might be (aside from security concerns of loading data from a config file).

$PM = "Perl Monk's";
$MCF = "Most Clueless Friar Abbot Bishop Pontiff Deacon Curate";
$nysus = $PM . ' ' . $MCF;
Click here if you love Perl Monks

In reply to Singleton method wrappers for config file properties: Bad idea? by nysus

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.