You've got -w , but not use strict. While I think your code is strict already, it's always a good idea to have this.

It's much easier to glob a file list, than to use a system call; the former is more portable than other methods. That is, you can reduce your pre-function code to : 

#!/usr/bin/perl -w
use strict;
use HTML::Clean;
clean_file( $_ ) foreach glob "*.html";

[download]
You should always catch errros from file system calls like open, that is, you should do open (OUTPUT, ">$filename") or die "Can't open $filename: $!"; to get meaningful errors.

IMO, it would also be better to write to a temporary file then move the file over using rename than to write over an existing file. This would minimize the chance of errors losing any original HTML files to start with.

Everything else seems good from a programmer's standpoint.

-----------------------------------------------------
Dr. Michael K. Neylon - mneylon-pm@masemware.com || "You've left the lens cap of your mind on again, Pinky" - The Brain
It's not what you know, but knowing how to find it if you don't know that's important

In reply to Re: Improvement suggestions? by Masem
in thread Improvement suggestions? by sheridan3003

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.