my $dbh = DBI->connect("um","","","mysql") ||
die "Could not connect: $DBI::errstr\n";

This should be:</> 

my $dbh = DBI->connect("DBI:mysql:$host", $user, $pass) ||
    die "Could not connect: $DBI::errstr\n";

[download]

Your SQL statement needs to be a quoted string:

my $sth = 
  $dbh->prepare("INSERT into people (fornavn, efternavn, 
                                     cpr, adresse, zip, 
                                     city, tjenestested) 
                 values ($fornavn, $efternavn, $cpr, 
                         $adresse, $zip, $city,   
                         $tjenestested"));

[download]

And I'm willing to bet that some of those column values should be quoted - but not knowing your schema, I can't tell which ones.

Also, you should check the return code from all of your functions:

my $sth = 
  $dbh->prepare("INSERT into people (fornavn, efternavn, 
                                     cpr, adresse, zip, 
                                     city, tjenestested) 
                 values ($fornavn, $efternavn, $cpr, 
                         $adresse, $zip, $city,   
                         $tjenestested"))
  || die $dbh->errstr;

$sth->execute || die $dbh->errstr;
$sth->finish  || die $dbh->errstr;

[download]
--
<http://www.dave.org.uk>

"The first rule of Perl club is you don't talk about Perl club."

In reply to Re: dbi insert by davorg
in thread dbi insert by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.