See the node use CGI or die;. You should not parse CGI form data by hand.

  1. print "Content-type:text/html\n\n";

    There should be a space between the colon and the t.

  2. read(STDIN, $buffer, $ENV{'CONTENT_LENGTH'});

    You don't check to see if the read was successful. Does the length match CONTENT_LENGTH?

  3. @pairs = split(/&/, $buffer);

    The semicolon is an alternate delimeter that will be supported more in the future. This will break your code.

  4. $value =~ s/\r//g; # remove hard returns
  5. $value =~ s/\cM//g; # delete ^M's

    Do you realize that \cM is the same as \r?

  6. $FORM{$name} = $value;

    Whoops! If we have multiple values, you've just overwritten them.

You can replace all of that broken code with the following three lines:

use CGI qw/ :cgi-lib :standard /;
print header;
my %FORM = Vars;

[download]

Cheers,
Ovid

Vote for paco!

Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.

In reply to (Ovid) Re: Storable: freeze/unfreeze by Ovid
in thread Storable: freeze/unfreeze by david.jackson

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.