This question has been more than answered, but i wanted to point out that this code could be much more maintainable if you stored the names of your CGI param variables (which, if you notice, are most conveniently the same as your database field names) in an array: 
my @fields = qw(fornavn efternavn cpr adresse zip city tjenestested);

my $cgi = new CGI;

# apply validation/error checking as needed
# in this case, if no param is found, undef is default
my @params = map { $cgi->param($_) || undef } @fields;

# connect to database . . .

my $sth = $dbh->prepare(
   'INSERT into people(' .
   join(',', @fields), ') values(' .
   join(',', map { '?' } @fields), ')'
) or die $dbh->errstr;

$sth->execute(@params) or die $dbh->errstr;

[download]
It looks a bit intimidating, but you only need to worry about changing ONE line (the first one in this example) if you add or subtract fields. Read up on map and join for more info. :)

jeffa

In reply to (jeffa) Re: dbi insert by jeffa
in thread dbi insert by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.