Is there any discernible improvement in this?

##Invoking subroutines

HashSequences();
SpecifySeqLengths(my $id, my %seq);

## Open file. Hash sequences. Make the sequence IDs the keys to their
## respective (hashed) sequences.


sub HashSequences{

    open F, "human_hg19_circRNAs_putative_spliced_sequence.fa", or die
+ $!;

    my %seq = ();
    my $id = '';

    while (<F>){
        chomp;
        if ($_ =~ /^>(.+)/){
            $id = $1;
        }else{
            $seq{$id} .= $_;
        }
    }
    close F;
    return (%seq, $id);
}

## Request sequence length desired. Sieve sequences of given length in
+to
## arrays. Create file containing desired sequences.

sub SpecifySeqLengths{

    print "Enter Max sequence length: \n";
    my $maxlength = <STDIN>;
    chomp $maxlength;

    print "Enter Min sequence length: \n";
    my $minlength = <STDIN>;
    chomp $minlength;

    my @seqarray;

    foreach $id (keys %seq){
        if ((length$seq{$id} <= $maxlength) && (length$seq{$id} >= $mi
+nlength)){
            push @seqarray, $id;
        }
    }

    for $id (@seqarray){
        if (-f $id){print $id, " already exists. It is about to be ove
+rwritten"};
        open new_F, '>>', "SeqLength_$minlength-$maxlength", or die$!;
        print new_F ($id."\n".$seq{$id}."\n");
        close new_F;
    }

}

[download]

In reply to Re^4: I'm trying to consolidate my functions into subroutines by Peter Keystrokes
in thread I'm trying to consolidate my functions into subroutines by Peter Keystrokes

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.