G'day shoura,
Here's some techniques for removing redundant and duplicated processing.
-
There's a single pass through the SEQ file.
Trimming leading and trailing whitespace, as well as the line terminator, uses a single regex capture.
The replacement text, for later use, is calculated once here.
-
The regex for use when processing the TXT file is created once only.
-
There's a single pass through the TXT file; and there's no nesting.
The substitution, using values already calculated, is the only processing done here.
-
I've used Inline::Files as the actual opening and closing
of your files doesn't appear to need optimising.
Having said that, I would urge you to use lexical filehandles throughout,
and the 3-argument form of open.
#!/usr/bin/env perl
use strict;
use warnings;
use Inline::Files;
my %seq;
while (<SEQ>) {
my ($trim) = /^\s*(.*?)\s*$/;
($seq{$trim} = $trim) =~ s/\h+/bbb/g;
}
my $re = qr{(@{[join '|', sort { length $b <=> length $a } keys %seq]}
+)};
while (<TXT>) {
s/$re/$seq{$1}/g;
print;
}
__SEQ__
scooped up by
social travesty
without proper sanitation
__TXT__
Many of them are scooped up by chambermaids, thrown into bin bags and
+sent off to landfill sites, which is a disaster for the environment a
+nd a social travesty given that many people around the world are goin
+g without proper sanitation.
Output:
Many of them are scoopedbbbupbbbby chambermaids, thrown into bin bags
+and sent off to landfill sites, which is a disaster for the environme
+nt and a socialbbbtravesty given that many people around the world ar
+e going withoutbbbproperbbbsanitation.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.