You should have used <code> and </code> to delimit your code. it makes it much easier to read

Despite that i dont think you understand the nature of how cgi works. Each time that runs because the user pressed verify it generates a new $answer, that bears no relationship to whatever was typed into $useranswer the previous time it was displayed to the user. This is what you test against the users answer so it is bound not to match this run.

I dont do capcha stuff much, but i would include a hidden string to return in the post. This hidden string would have been used to create the previous "$answer" in a way that the end user would not be able to replicate easily. When this parameter is found in the reply you would then use it to regenerate the previous answer and compare it to what was returned in $useranwser. I might pick CGI::Session as the mechanism to store the previous answer and have the sessionid be used as the returned value to regenerate the $answer.

Edit: add example code 

#!/usr/bin/perl
use strict; use warnings; 
select STDOUT; $| = 1;

  my $session_dir='/home/huck/monks-sessions';  # must exist and be wr
+iteable by www userid 
  my $expires='+1m';


  use CGI;

  use CGI::Session;

  my $session; 

  my $cgi = CGI->new;

  my $tssid  = $cgi->param('tssid');

  my $sessiona1=undef; 
  my $sessiona3={Directory=>$session_dir}; 

  unless ($tssid){ 
      new_capcha('');
      } # no tssid 
  else { 
      $session = CGI::Session->load($sessiona1, $tssid, $sessiona3);
      if ( $session->is_expired )    { 
          $session->delete(); 
          $session->flush();
          new_capcha('Try again: took too long');
          } 
      elsif ( $session->is_empty )   { 
          $session->delete(); 
          $session->flush();
          new_capcha('Try Again:Session not found');
          } 
      else { 
          my $oldanswer=$session->param('answer');
          my $useranswer= $cgi->param('useranswer');
          if (uc($oldanswer) ne uc($useranswer)) { 
              $session->delete(); 
              $session->flush();
              new_capcha('Try Again:didnt Match');
              } 
          } 
      } 
# the only way it can get here is if answer is right 
      print $cgi->header(); 
          print <<EndgoodHTML;
<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=windows-12
+52">
<title>My Capcha</title></head>
<body>
You won
</body></html>
EndgoodHTML
  CGI::Session->find($sessiona1 ,sub {} ,$sessiona3); # clean expired 
+sessions 

exit; 

sub new_capcha{ 
  my $reason=shift; 
  $session = CGI::Session->new($sessiona1, undef,$sessiona3);
  my @chars = ("A".."Z", "a".."z");
  my $answer;
  $answer .= $chars[rand @chars] for 0..4;
  $session->expires($expires);
  $session->param('answer',$answer);
  $session->flush(); 
  $tssid= $session->id; 
  print "Content-type:text/html\n\n";
  print <<EndHTML;
<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=windows-12
+52">
<title>My Capcha</title></head>
<body background="http://www.astrologybythesea.com/images/bg_coastR.jp
+g">
<!-- <p><u><font size="5" color="#0000FF">My Capcha</font></u></p> -->
<form action="/monks-bin/capcha.pl" method="post">
<table width="100%" border="0">
<center>
<h5>AntiBot Verifiication</H><br />
$reason 
<div>
<font size="2">$answer</font></div>
<!-- Now get users input -->
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbs
+p;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
<input type="text" size="8" maxlength="8" name="useranswer" value="">
<input type="hidden" name="tssid" value="$tssid">
<input type="submit" name="verify" value="Verify"><br />&nbsp;&nbsp;&n
+bsp;Type the above characters
</h5></center></table></form></body></html>
EndHTML
exit; 
} # newcapcha

[download]

In reply to Re^3: Random F%^k up strings! by huck
in thread Random F%^k up strings! by TroyH

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.