Yes, Anonymous Monk, you're correct, this while loop has a bug when one of the values in the array is 0.

IMHO, this array traversal should really be made with a for loop, as it is usually better to use a for loop to iterate over an array, but the OP did not specify very clearly what was authorized and what not.

This is what it might look like with a for loop. 

use strict;
use warnings;

my @array = (-11,-13,4, 22, 17);
print find_max_odd(@array), "\n";
sub find_max_odd {
    my $max;
    for my $num (@_) {
        next unless $num % 2;
        $max = $num unless defined $max;
        $max = $num if $num > $max;
    }
    return defined $max ? $max : "No odd number found\n";    # this co
+uld be replaced with if conditional statements if needed
}

[download]

In reply to Re^3: John Guttag's book - 2nd exercise. My attempt in Perl. by Laurent_R
in thread John Guttag's book - 2nd exercise. My attempt in Perl. by pritesh_ugrankar

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.