Okay, so your first problem seems to be that you're not getting your input correctly. I've added strictand warnings and the commensurate mystatements, and then used Data::Dumperto show what you're collecting:

#!usr/bin/perl use strict; use warnings; use Data::Dumper qw(Dumper); my @car_list = (); open(INPFIL,"cars.dat") || die("Couldnt open the file \n"); while(<INPFIL>) { if(/^\s*CARS\s*[A-Z]/) { my ($car)=$_=/^\s*CARS\s*(\w+)/; push(@car_list,$car); } } print Dumper @car_list; exit;

The output shows you're collecting a bunch of 1s:

S:\Steve\Dev\PerlMonks\P-2017-05-29@0722-Cars-Arrays-Groups>perl cars0 +.pl $VAR1 = 1; $VAR2 = 1; $VAR3 = 1;

Nothing else matters until you fix that. This is a variant of what we used to, in the profession, call "garbage in, garbage out".

Now, I could tell you why you're collecting 1s instead of car manufacturers, but it's a good exercise for you to take a stab at explaining why.

What's your best guess(es)?


In reply to Re: Matching probem by marinersk
in thread Matching probem by Nansh

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.