I have written very few (2) XS modules for wrapping other code, and a few XS modules for companies from scratch ... making me less than an authority on XS, but from what i see here, this code should work very well.

I would assume that <code lang="C">HPERRMSG()</code> allows for a NULL pbuf, but not knowing the function, depending on what this is, you may want to return if it is NULL ... but since i don't know <code lang="C">HPERRMSG()</code>, i am possibly very wrong.

Last thing, and this is just me, i would suggest returning a status of some sort. Something as simple as 1 on success and <code lang="C">PL_undef</code> for failure. That way, even if <code lang="C">HPERRMSG()</code> returns void, you can return in the event of bad arguments (non-numeric, etc)

my $cents = 2;

In reply to Re: XS help by MZSanford
in thread XS help by Thelonius

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.