I am beginner to perl ,so if you could help to optimized my code with perform below step ... i will be great help if you can correct where ever in code,I'm missing basic perl syntax and line not relevant..

For a beginner, your code looks pretty good, and there are no syntax errors in it (including the commented out code). Are you having problems with it? If so, feel free use the resources of PerlMonks, e.g. Basic debugging checklist and How do I post a question effectively?

Because the code depends on XML input and servers I don't have available to me, I can't run it, but from a quick read-through I have the following suggestions for improvements:

• The first line should be #!/usr/bin/perl (or perhaps #!/usr/bin/env perl to use whatever Perl is in the PATH).
• You don't need both use JSON; and use Cpanel::JSON::XS qw(encode_json);, I think the latter is enough.
• I don't think you need use DateTime::Duration; or use DateTime::Format::Duration;.
• As I said, I would suggest you replace my $records = []; with my @records, and then every @$records with @records.
• You don't seem to be using $count.
• You do this several times: $var =~ s/\n//; which will remove the first newline character from the string. It's also possible that the XML data might change in the future, so I might recommend the following, more flexible regex, which will trim all whitespace from the beginning and end of the string: s/^\s+|\s+$//g
• Don't reformat $timereceived with regexes, just adjust the strptime pattern accordingly: '%Y-%m-%dT%H:%M:%S.%3NZ'
• I suggest you move my $dtnow = DateTime->now; before the loop.
• This code doesn't match the comment: if ($diff_hours>2000) { # Get the event details which are more then 2 hours
• While you're free to use a module like Math::Round if you need precise control, note that Perl's sprintf will also do basic rounding for you: sprintf("%.0f h", $diff_hours);

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.