I've just checked with my Strawberry Perl (perl 5, version 18, subversion 2 (v5.18.2) built for MSWin32-x64-multi-thread), using the following patch to the 3 files (specified in the
bug report):
--- ../Audio-Scan-0.98-1/Scan.xs 2017-07-12 23:26:41 +1000
+++ Scan.xs 2017-07-12 23:25:17 +1000
@@ -12,7 +12,7 @@
#endif
// Headers for stat support
-#ifdef _MSC_VER
+#ifdef __WIN32__
# include <windows.h>
#else
# include <sys/stat.h>
@@ -185,7 +185,7 @@
uint64_t size = 0;
uint32_t hash;
-#ifdef _MSC_VER
+#ifdef __WIN32__
BOOL fOk;
WIN32_FILE_ATTRIBUTE_DATA fileInfo;
--- ../Audio-Scan-0.98-1/include/common.h 2017-07-12 23:26:52 +1000
+++ include/common.h 2017-07-12 23:24:48 +1000
@@ -33,7 +33,7 @@
#define DEFAULT_BLOCK_SIZE 4096
-#ifndef _MSC_VER
+#ifndef __WIN32__
// We use the built-in GUID type on Windows
typedef struct _GUID {
uint32_t Data1;
--- ../Audio-Scan-0.98-1/src/common.c 2017-07-12 23:27:09 +1000
+++ src/common.c 2017-07-12 23:24:10 +1000
@@ -205,7 +205,7 @@
off_t
_file_size(PerlIO *infile)
{
-#ifdef _MSC_VER
+#ifdef __WIN32__
// Win32 doesn't work right with fstat
off_t file_size;
Works fine for me.
And it should work fine with any ActiveState Perl for which 'perl-V:cc' reports that 'cc' is 'gcc'.
I must say that I find it exceedingly annoying that the author has done nothing to remove the need for this patching.
Audio-Scan-0.98 was released just 3 months ago, though the
bug report was filed over 5 years ago !!
Cheers,
Rob
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.