G'day 345qwerty,

"Do you have any suggestions?"

If you write code that messy, you can be pretty much guaranteed to make mistakes. Choose a code layout that suits you and use it consistently. See "perlstyle - Perl style guide" for tips on how to accomplish this. Consider using "perltidy - a perl script indenter and reformatter".

open(FILE, "<", "Q.txt");

Use lexical filehandles instead of global, package variables. Check that I/O operations actually worked. See open and the autodie pragma.

while($number <= $#column) { #go through the array from +0 to the last element $number++; }

This is an inappropriate method for iterating an array. If you just want the elements:

for my $element (@array_name) { # Do something with $element here }

If you really need the indexes:

for my $index (0 .. $#array_name) { # Do something with $index here }

I might have further suggestions after you've tidied up the code.

— Ken


In reply to Re: Create separated column for my file by kcott
in thread How can I print all lines? by 345qwerty

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.