To open a filehandle once the easiest way would be to have one central function for opening a file that caches the filehandle:

my %filehandles; sub open_file { my( $filename ) = @_; if( ! $filehandles{ $filename }) { open $filehandles{ $filename }, '>>', $filename or die "Couldn't append to '$filename': $!"; }; return $filehandles{ $filename } } ... my $fh = open_file( 'path1' ); print $fh "Hello\n"; my $fh2 = open_file( 'path1' ); print $fh2 "world!\n";

As for your programming style, you are launching external processes several times to retrieve information. This can lead to inconsistent errors if a service comes up or goes down between your two queries. Better retrieve the information one into an array. Also, don't use an external grep command when Perl has a built-in grep:

my @services = `systemctl list-unit-files`; if( my @smb = grep { /smb\.service/ } @services ) { my $fh = open_file( 'path1' ); print DATEI "chkconfig smb: OK\n"; print DATEI "Output:_\n " . join( "", @smb) . \n\n; };

Update: The return statement in the function was wrong. Spotted by soonix++


In reply to Re: Open Filehandle once by Corion
in thread Open Filehandle once by Dunkellbusch

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.