map { $_ . '=' . sanitize($cgi->param($_)) } sanitize($cgi->param())

Assuming the call to $cgi->param() returns a list1, this list is first passed to sub sanitize which returns a scalar, so the input to map will only ever be a single value.

Actually, it gets worse. The $ prototype to sub sanitize coerces the argument list into a scalar, so if a list of, say, 3 values is passed in, $s will have the value 3!2 Removing the prototype helps, but you still get only a single value. You need something like a second map:

map { $_ . '=' . sanitize($cgi->param{$_}) } map { sanitize($_) } $cgi
+->param()

[download]

Also note that the $cgi->multi_param() method is preferred to the $cgi->param() method when a list is returned.3

And if the call to $cgi->param{$_} can itself return a list and not just a scalar, then yet another level of looping will be needed.

1It may return a list or a scalar, depending on how the script was invoked. See “Fetching the names of all the parameters passed to your script” in CGI.
2See Far More Than Everything You've Ever Wanted to Know about Prototypes in Perl for the details.
3See the warning in “Fetching the value or values of a single named parameter” in CGI.

Hope that helps,

Athanasius <°(((>< contra mundum Iustus alius egestas vitae, eros Piratica,

In reply to Re^3: problem with Crypt::PBKDF2 by Athanasius
in thread problem with Crypt::PBKDF2 by jamroll

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.