Hi bisimen,

your error is in this line: 

    $mass .= "$mass_values{$codon}\n";

[download]
This line concatenates all the masses (interleaved with a new line), whereas you want to sum them up. So, in the end, you get a large string with all the masses, each on its own line. Just replace concatenation with addition: 
    $mass += $mass_values{$codon};

[download]
and your first program should do what you want, without the need for the second one.

There are other improvements that could be made: use strict, don't use no warnings 'uninitialized'; just to silence the warnings, but try to remove the warnings by understanding where they come from (possibly a new line character at the end of your string in the file), chomp the line you read from the input file, use split to get the individual letters of the protein string (see choroba's example above).

In reply to Re: Adding values in a variable by Laurent_R
in thread Adding values in a variable by bisimen

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.