Hi, This cannot be your code; it does not compile. After removing the comma from the opening brace of the subroutine, I get "Can't use an undefined value as a HASH reference".

Maybe you want something more like this?

use strict; use warnings; use feature qw/ say /; my @captains = qw/ kirk picard popeye /; my $commanded_by = trivia( @captains ); for my $captain ( sort keys %{ $commanded_by } ) { say sprintf '%s was on Enterprise #: %s', ucfirst $captain, join ', ', @{ $commanded_by->{ $captain } }; } sub trivia { my @captains = @_; my %commands = ( kirk => [ 'EntTOS', 'EntA' ], picard => [ 'EntD', 'EntE' ], ); my %output; $output{ $_ } = $commands{ $_ } || [] for @captains; return \%output; } __END__
Output:
$ perl 1202155.pl Kirk was on Enterprise #: EntTOS, EntA Picard was on Enterprise #: EntD, EntE Popeye was on Enterprise #:

Hope this helps!


The way forward always starts with a minimal test.

In reply to Re: Replacing original hash with modified hash returned from subroutine by 1nickt
in thread Replacing original hash with modified hash returned from subroutine by CommaSplice

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.