As I use Moose more, I've found it is easy to use some of its mechanisms in ways they probably were not intended to be used and that this can lead to confusing code. One of the things I've been doing is to use the BUILD method to set object attributes. For example, I've got this:

package 'Blah';

use Moose;

has attributes => ( isa => 'HashRef' );
has attr1 => ( snip );
has attr2 => ( snip );
has content => (isa => 'HTML::Element'); 

sub BUILD {
  my $s = shift;

  # add attributes to object and/or HTML::ELEMENT in content attribute
  foreach my $attrib (keys %{$s->attribs}) {
    # set attributes of an object if it exists
    if ($s->can($attrib)) {
        $s->$attrib($s->attribs->{$attrib});
      }
    # set attributes of #HTML::ELEMENT
    } else {
      $s->content->attr($attrib, $s->attribs->{$attrib});
    }
  }
}

[download]

In one way this is convenient as I can just smash all the attributes into one hash and let the class figure out how to process it. I'm now rethinking this, however. I'm wondering what others think. Thanks!

$PM = "Perl Monk's";
$MCF = "Most Clueless Friar Abbot Bishop Pontiff Deacon Curate Priest";
$nysus = $PM . ' ' . $MCF;
Click here if you love Perl Monks

In reply to Is setting attributes with BUILD in Moose a bad idea? by nysus

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.