G'day ddrew78,

"Any wisdom at all would be greatly appreciated."

It would be wise to:

• ask Perl to do some basic checks for you (see strict and warnings);
• do some basic checking yourself (e.g. does @ip_fields contain exactly four elements all of which match /^\d+$/);
• use lexical variables (e.g. $tunip is not lexical); and,
• show us actual input and output, which might include warning or error messages, such that we can comment on why particular input "just leaves '$bgp_ip' blank" (see "How do I post a question effectively?").

Furthermore, your descriptive text and programmed logic are at odds with each other:

$ perl -E 'my @x = split /\./, "10.1.1.5"; $x[3] % 2 ? --$x[3] : ++$x[
+3]; say join ".", @x'
10.1.1.4
$ perl -E 'my @x = split /\./, "10.1.1.6"; $x[3] % 2 ? --$x[3] : ++$x[
+3]; say join ".", @x'
10.1.1.7
[download]

You could reverse the logic to match the text:

$ perl -E 'my @x = split /\./, "10.1.1.5"; $x[3] % 2 ? ++$x[3] : --$x[
+3]; say join ".", @x'
10.1.1.6
$ perl -E 'my @x = split /\./, "10.1.1.6"; $x[3] % 2 ? ++$x[3] : --$x[
+3]; say join ".", @x'
10.1.1.5
[download]

But then you'd have edge case problems not addressed by either your description or code:

$ perl -E 'my @x = split /\./, "10.1.1.0"; $x[3] % 2 ? ++$x[3] : --$x[
+3]; say join ".", @x'
10.1.1.-1
$ perl -E 'my @x = split /\./, "10.1.1.255"; $x[3] % 2 ? ++$x[3] : --$
+x[3]; say join ".", @x'
10.1.1.256
[download]

So, there's potentially issues at a fundamental level (e.g. problem analysis, solution design, coding logic); and there's clearly problems with a lack of basic checking and validation.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.