Use hash keys to avoid lots of variables. Push the field names, values onto arrays and use join to create the statement

#!perl
use strict;

my $user_id = 1;

my $old = {
  password => 'password', forename  => 'forename',
  lastname => 'lastname', business => 'business',
  city     => 'city',     zip      => 'zip'
};

my $new = {
  password => 'password1',  forename  => 'forename',
  lastname => 'lastname1', business => 'business',
  city     => 'city1',     zip      => 'zip1'
};

my @fields;
my @values;
# compare old v new
for (sort keys %$new){
  if ($new->{$_} ne $old->{$_}){
    push @fields,"$_ = ?";
    push @values,$new->{$_};
  }
}

# skip if no change
if (@fields == 0){
  print "No update required\n";
} else {
  # build sql
  my $fields = join ',',@fields;
  my $stmt = "
   UPDATE table 
   SET $fields
   WHERE user_id = ?";
   # add id
   push @values,$user_id;
   
   # prepare and execute sql
   print "$stmt\n(@values)\n"; 
}

[download]
poj

In reply to Re^5: CGI Action call by poj
in thread CGI Action call by tultalk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.