If $image is '' or undefined, then $file would be "F:/images/". If the directory F:/images exists, then -e would be true. If you used "use warnings;" you'd at least get a warning in the undefined case.

I'd suggest also using -f instead of -e, as -f would be true only if it exists and is a file rather than a directory:

$ perl u.pl
Use of uninitialized value $file in concatenation (.) or string at u.p
+l line 16.
Use of uninitialized value $file in concatenation (.) or string at u.p
+l line 21.
OK, missing
OK, missing
OK, OK
$ cat u.pl
use strict;
use warnings;

my $f1;
my $f2='';
my $f3='README';

my $dir='./xyz';

print chk($dir, $f1), ", ", chk2($dir,$f1),"\n";
print chk($dir, $f2), ", ", chk2($dir,$f2),"\n";
print chk($dir, $f3), ", ", chk2($dir,$f3),"\n";

sub chk {
    my ($dir, $file) = @_;
    return -e "$dir/$file" ? "OK" : "missing";
}

sub chk2 {
    my ($dir, $file) = @_;
    return -f "$dir/$file" ? "OK" : "missing";
}

[download]

...roboticus

When your only tool is a hammer, all problems look like your thumb.

In reply to Re: Check if file exists by roboticus
in thread Check if file exists by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.