system("uuencode ${logfile} ${logfile} | mailx -s ${subject} -r ${rec
+ipient1}");
Let's hope nobody sets subject to `rm -rf /`. You have created a shell injection vulnerability. Try to avoid using the shell, as others told you. If you absolutely can not avoid the shell, use the multi-argument form. See The problem of "the" default shell for the ugly details.
And as a bonus, you are not comparing here, but assigning:
if ($userid = $user1){
system("uuencode ....")
As long as $user1 contains a true value (i.e. everything but undef, 0 or the empty string), system will be executed, no matter what $userid once contained.
If you want to compare strings, use eq. For numbers, use ==. (How to remember that.)
Alexander
--
Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.