I am trying to enhance a user creation script written in perl; I am using active perl on Win 10 I have attached an excerpt in which I am trying to account for multiple first names in a user, so that the people who use the script do not have to edit the input file to have a single first name The loop I created to create a capitalised and spaced names, does not put in the space that I would expect

use strict;

#except to test my code

#do the fancy stuff here for multiple Christian names
#count how many firstnames

#first would have been read in from a text file, but is explicit here
my $first = "billy bob allan";
    my @nfirst = ();
    @nfirst = split (/\s/,$first);
    print "name $first has ".(scalar(@nfirst))." names\n";
    
    #put a value onto number of names
    my $Numfirst = scalar(@nfirst);
    
    #Now I am hopefully be elegantr here and captialise and space them
    my $newfirst=();
    for ( my $i=0;$i < $Numfirst;$i++) {
    #print "name part is ".ucfirst $nfirst[$i]."\n";
    $newfirst .= join(" ",(ucfirst $nfirst[$i]) );
    
    }
    
    print "new first name is $newfirst\n";
    
    #doing it as per perldoc
    my $NewFirst= join(" ", 'Billy', 'Bob', 'Allan');
    
    print "new first name is $NewFirst\n";

[download]

Any suggestions as to why my code does not work as expected

David

In reply to trying to use join in a loop by lamasculo

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.