An easy (but not the best) way to fix the error is to use a concatenation instead of join:

# $newfirst .= join(" ",(ucfirst $nfirst[$i]) );
 $newfirst .= " " . ucfirst $nfirst[$i];

[download]

There seems to be some confusion between arrays and scalars in your code. $newfirst is a scalar, so initializing it with () doesn't do anything. join takes a separator and a list as arguments and puts the separator between adjacent elements of the list, but you feed it one element at a time so there never are adjacent elements.

One more idiomatic solution would be to use map instead of looping through the list of names (in fact, there's not many cases where you need to write C-style loops in Perl), like this:

use strict;

#except to test my code

#do the fancy stuff here for multiple Christian names
#count how many firstnames

#first would have been read in from a text file, but is explicit here
my $first = "billy bob allan";
my @nfirst = ();
@nfirst = split (/\s/,$first);
print "name $first has ".(scalar(@nfirst))." names\n";

my @newfirst = map { ucfirst } @nfirst;

print "new first name is @newfirst\n";

[download]

You could also do it in one go with a regex, which for the moment I leave as an exercise to the reader :)

In reply to Re: trying to use join in a loop by haj
in thread trying to use join in a loop by lamasculo

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.