And now, rather than declaring and preparing the queries once per array element, you can lift them outside the loops:

my $sth = $db->prepare("SELECT curr_parent_id FROM demstock2 WHERE ds_
+id=?");
my $move_sth = $db->prepare("UPDATE demstock2 SET curr_parent_id=? WHE
+RE ds_id=?");
my $action_sth = $db->prepare("
INSERT INTO action
(action_id, action_type, ds_id, occurred,          ref_no,  staff_id) 
+VALUES
(NULL,      'MOVE',      ?,     CURRENT_TIMESTAMP, ?, ?)");
for my $child (@built, @acc) {
  #Find out if it still is in free stock
  $sth->execute($child) or ...
  my $current_status = $sth->fetchrow_hashref;
  if($current_status->{"curr_parent_id"} != 0) {
    print ...;
    next;
  }
  $move_sth->execute($main, $child) or ...
  $action_sth->execute($child, "0,$main", $caluser) or ...;
}

[download]
That's why placeholders rock :-)

--
Tommy
Too stupid to live.
Too stubborn to die.

In reply to Re: Re: Re: A question of style. by tommyw
in thread A question of style. by davis

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.