Opps sorry, my actual code looks closer to

sub makeinsert{ die "no table" unless ($args{table}); my $table =$args{table}; die "no table" unless ($args{dbh}); my $dbh =$args{dbh}; die "no varlist" unless ($args{varlist}); my @vl=@{$args{varlist}}; my $repeat =$args{repeat}; $repeat=1 unless ($repeat); my @q=map{'?'} @vl; my $plist=' ('.join (',',@q).') '; my @aplist; for my $ii (1..$repeat) { push @aplist,$plist; } my $plistn=join (",\n",@aplist); my $sql='INSERT INTO '.$table.' ('.join (',',@vl).' ) values '.$plistn; my $handle=$dbh->prepare($sql); die "Couldn't prepare ".$table." insert; aborting" unless defined $handle ; return $handle; } my $sth2_1000=makeinsert(dbh =>$dbh2 ,table =>'table_name' ,repeat =>1000 ,varlist =>[qw/col_1 col_2 col_3 col_4 col_5/] );
And i missed that comma, noticing only the \n, in my haste to simplify it for you.


In reply to Re^2: How to insert 30-50K rows into MySQL DB using DBI? by huck
in thread [SOLVED]: How to insert 30-50K rows into MySQL DB using DBI? by Perl300

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.