I'm working on some old code and came across this
package Person;
use Moose;
has 'label' => ( is => 'rw', isa => 'Str' );
has 'shift' => ( is => 'rw', isa => 'Str' );
#### then, in the script
my $Person = Person->new;
if($hash->{label}) { $Person->label( $hash->{label} ); }
if($hash->{shift}) { $Person->shift( $hash->{shift} ); }
Perl Critic is highlighting the last line with
autoderef is deprecated [...] Use of each/keys/pop/push/shift/splice/
+unshift/values on a reference is an experimental feature...
I can see why perlcritic thinks this but any idea how I should deal with it?
Thanks
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.