Change it to a while loop:
while (@files) { ...
That should fix your problem, cause it'll only loop as long as there are elements in @files. Whereas yours was actually looping *over* @files, which is a different thing, and not recommended if you're going to be modifying @files (which you did, by using shift).

Alternatively, though, you may want to try using splice:

push @data, [ splice @files, 0, $num_cols ] while @files;
splice grabs chunks of an array (and can also replace those chunks w/ a list) and increases/decreases the size of the array as necessary. Sounds good for your particular use.

In reply to Re: Why doesn't this for loop work like I expect? by btrott
in thread Why doesn't this for loop work like I expect? by husker

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.