Hi there Monks,

Lately I've been working a lot with storing CSV content (after some parsing of the data) in a database. In a lot of cases the data allready is in the database, in which case I want to update it. Familiar problem I guess. I came up with this solution:

  connectDB();
  my $insert = "Insert Into table (id,name) Values (?,?)";
  my $update = "Update table set name = ?  Where id=?";
  my $sth_insert = $dbh->prepare($insert) or die $dbh->errstr;
  my $sth_update = $dbh->prepare($update) or die $dbh->errstr;

  for my $data (@$data_ref){
    if (! $sth_insert->execute(
                                $$data{'id'},
                                $$data{'name'}
                               ) ){
      print 'Insert error: '.$sth_insert->errstr if $debug;
      print "Doing update\n";
      $sth_update->execute(
                                $$data{'name'},
                                $$data{'id'}
                          ) or die("Insert and Update failed, update: 
+".$sth_update->errstr );
    }
  }
  $sth_insert->finish();
  $sth_update->finish();
  disconnectDB();

[download]

As it turns out the $sth_update is never executed, or at least the database does not reflect it... The insert goes as expected. I do get the "Doing update" message. Any ideas on what Im doing wrong here?

In reply to My update on insert error solution by PeterKaagman

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.