Two things I see right off the bat: First, you've got nested loops (for(my $m=0; $m<$length; $m++) { for(my $l=2; $l<2990; $l++) { ...) for a simple string equality search, where the outer loop could be removed and replaced by a much faster hash lookup. Second, inside the loop, you're making a ton of OLE calls with $Sheet2->Cells($l,$Signalcolumn)->{'Value'} - it'd be better if you cache this in a local variable. Something like this (untested):

my %longNames = map { ($_=>1) } @longNames; for my $l (2..2990) { my $v = $Sheet2->Cells($l, $Signalcolumn)->{'Value'}; next unless length $v; if ( $longNames{$v} ) { $Sheet2->Cells($l, 100)->{'Value'} = "matched"; print"\n***********Matched*************\n"; } }

Update: Now tested, and I can confirm it runs much faster. Note that you really should Use strict and warnings, you've got a couple of undeclared variables like $startingrow.


In reply to Re: Xls reader (updated) by haukex
in thread Xls reader by sainky

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.