It does look more elegant and compact, but it's significantly slower:
$ perl ./thescript
Benchmark: timing 1000 iterations of orig, tybalt89...
     orig:  3 wallclock secs ( 2.48 u + 0.00 s =  2.48 CPU) @403.23/s (n=1000)
 tybalt89: 10 wallclock secs (10.22 u + 0.00 s = 10.22 CPU) @ 97.85/s (n=1000)
#!/usr/bin/perl use strict; use warnings; use Benchmark qw(timethese); sub solve1 { my ( $goal, $elements ) = @_; my ( @results, $RecursiveSolve, $nextValue ); $RecursiveSolve = sub { my ( $currentGoal, $included, $index ) = @_; for ( ; $index < @$elements ; ++$index ) { $nextValue = $elements->[$index]; if ( $currentGoal > 2 * $nextValue ) { $RecursiveSolve->( $currentGoal - $nextValue, [ @$included, $nextValue ], $index + 1 ); } else { if ( $currentGoal == $nextValue ) { push @results, [ @$included, $nextValue ]; } return if $nextValue >= $currentGoal; } } }; $RecursiveSolve->( $goal, [], 0 ); undef $RecursiveSolve;#Avoid memory leak from circular reference return @results; } sub solve2 { my $want = shift() or return []; $want > 0 or return (); my ( $first, @rest ) = @{ shift() } or return (); map( [ $first, @$_ ], solve2( $want - $first, \@rest ) ), solve2( $want, \@rest ); } my @results; my @tosolve=(869,[15,43,51,56,60,67,122,152,193,204,229,271,293,301]); timethese( 1000, { 'orig' => sub { solve1(@tosolve) }, 'tybalt89' => sub { solve2(@tosolve) } } );

In reply to Re^2: Perl ARRAY() result by kschwab
in thread Perl ARRAY() result by pvfki

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.