Always best to use placeholders in your queries if possible

#!/usr/bin/perl
use strict;
use warnings;
use DBI;
use Text::CSV_XS;

# DBI CONNECTION
my $dbh = get_dbh();

my @id = @ARGV;
unless (@id){
  # no ids in ARGV
  my $sql = "SELECT DISTINCT id from mytable
             WHERE active = ?";
  @id = map{ $_->[0] } $dbh->selectall_array($sql,undef,'no');
}

# MAIN
for my $id (@id){
  my @query = (
    ["SELECT id FROM mytable     WHERE id=? AND salary >= 1","csvfile1
+_$id.csv"],
    ["SELECT name FROM mytable   WHERE id=? AND salary >= 1","csvfile2
+_$id.csv"],
    ["SELECT salary FROM mytable WHERE id=? AND salary >= 1","csvfile3
+_$id.csv"],
    ["SELECT dept FROM mytable   WHERE id=? AND salary >= 1","csvfile4
+_$id.csv"],
  );

  for (@query){
    run_query(@$_,$id);
  }
}

# SUBROUTINES
sub run_query 
{
    my ($sql, $csvfile,$id) = @_;
    print "Running $sql for $id\n";
    
    open my $fh, '>', $csvfile or die "Could not open $csvfile: $!";

    my $csv = Text::CSV_XS->new ({ binary => 1, eol => "\n" });
    my $sth = $dbh->prepare ($sql); 
    $sth->execute($id);
    $csv->print($fh, $sth->{NAME_lc});
    my $count = 1;
    while (my $row = $sth->fetchrow_arrayref)
    {
        $csv->print($fh, $row);
        ++$count;
    }
    close $fh;   
    print "ID: $id, $count lines dumped to $csvfile\n";
}

sub get_dbh
{
    my $dbname = "jtech";  my $user = "jtech";
    my $dbh = DBI->connect("dbi:IngresII:$dbname",$user,'')
      or die "Could not connect to database $dbname\n";  
    return $dbh;
}
[download]

poj

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.