it being perl? Your boss?

If you make errors like these it is likely not do do what you expect it to do.

• I used code tags
• I restyled the code for readability
• I fixed all obvious errors
• I commented on the changes with # <-
• I replaced the unmaintained parser with the right one: this is the main reason I reply.

HTH

use strict;                          # <- always use strict
use warnings;                        # <- and warnings

use Spreadsheet::WriteExcel;         # <- missing declaration
#use Spreadsheet::XLSX;              # <- this module is *STRONGLY* di
+scouraged!
use Spreadsheet::ParseXLSX;          # <- use this one instead

#my $excel = Spreadsheet::XLSX->new ("/tmp/temp.xlsx"); # <- do not us
+e Spreadsheet::XLSX
my $excel = Spreadsheet::ParseXLSX->new->parse ("/tmp/temp.xlsx");

# print $excel; # <- you cannot simply print an object and hope it wri
+tes a file
# if you want to see what this is use Data::Peek or Data::Dumper

#my @array;                          # <- unused
#my $workbook = Excel::Writer::XLSX->new ("perl.xlsx");
# ^--- Your code uses ->addworksheet, which is Spreadsheet::WriteExcel
+ syntax and
#      not supported by Excel::Writer::XLSX, so you obviously do not w
+ant this line

my $FILENAME   = "/tmp/Newfile.xls"; # <- used but commented out
my $workbook   = Spreadsheet::WriteExcel->new ($FILENAME); # <-- no qu
+otes needed
#  ^--- variable used twice
my $worksheet1 = $workbook->addworksheet ("Worksheet1");
$worksheet1->write ("A1", "Hi Excel!");
foreach my $sheet (@{$excel->{Worksheet}}) {
    print "Sheet: $sheet->{Name}\n"; # <- not really a good example fo
+r printf
    $sheet->{MaxRow} ||= $sheet->{MinRow};
    foreach my $row ($sheet->{MinRow} .. $sheet->{MaxRow}) {
        $sheet->{MaxCol} ||= $sheet->{MinCol};
        foreach my $col ($sheet->{MinCol} .. $sheet->{MaxCol}) {
            my $cell = $sheet->{Cells}[$row][$col] or next;
            printf "(%3d, %3d) => %s\n", $row, $col, $cell->{Val};
            my $temp = $cell->{Val};
            $worksheet1->write ($row, $col, $cell->{Val});
            }
        }
    last;                            # <- missing ;
    }                                # <- missing }
[download]

That code correctly created /tmp/Newfile.xls with one sheet named Worksheet1.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.