First suggestion: Use the special <CODE> tags around your code. Notice how your while clause got munged, that won't happen with code enclosed in <code> tags...

Second suggestion: The regex line in cpu_stat can be shortened... Since a m// regex returns ($1,$2,$3,etc) when called in list context, you can shorten that line to: 

($cpu_user, $cpu_nice, $cpu_total, $cpu_idle) = /^cpu\s+(\d+)\ (\d+) (
+\d+) (\d+)/;

[download]
Third suggestion, since you aren't actually doing anything with the individual values in the subroutine, don't even bother with multiple scalars... just use an array. Fourth: while seems overkill since you aren't really looping. Just grab one line w/o a loop.

Fifth: you can also remove the backslash before the space in your regex... 

sub cpu_stats {
   my @cpustats;

   open STAT_FILE, "/proc/stat" or warn "Couldn't open /proc/stat: $!\
+n";
   my $line = <STAT_FILE>;

   @cpustats = $line =~ /^cpu\s+(\d+) (\d+) (\d+) (\d+)/;
   close STAT_FILE;

   return(@cpustats);
}

[download]

-Blake

In reply to Re: suggestions for improvement by blakem
in thread suggestions for improvement by rendler

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.