I'm writing a script to run on macOS that will rename all illegal files in a tree, so they can go to OneDrive and Dropbox without jamming the processes.

I'm new to Perl and only a beginner hobby coder, dipping my toes into Perl, but I've learned a lot and asked a lot and have come up with this, which does everything but two things - check if a file is already open before renaming it. and avoid dot files.

I'm aware of lsof but I'm wondering if there's an easier and quicker way to check if any process in the system has a handle on a file open?

use warnings;
use File::Find;
use 5.010;
use POSIX;

find(\&dirRecurs, '/users/my-dir/tree-to-work-on');
sub dirRecurs{

        if ((my $txt = $_) =~ s/^\ | (?=\.)|[\/!#%^:<>?*&()\\]| $//g &
+& -f != m/^\./) {
                my $filename = '/users/my-dir/fix_names_report.txt';
                open(my $fh, '>>', $filename); 
                if (! -e $txt){
                    rename($_, $txt);
                    say $fh (strftime "%Y-%m-%d %H:%M:%S", localtime t
+ime)," \: ", $_, " => ", $txt;
                }
                else {
                    say $fh ("!!! ", strftime "%Y-%m-%d %H:%M:%S", loc
+altime time)," \: ", $_, " => NOT RENAMED =>", $txt, " already exists
+.";
                }
                close $fh;                
        }
       
}

[download]

Any advice or suggestions?

In reply to Easy way to check if a file is open needed. by Apt_Addiction

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.