Nothing really wrong that I (or anyone else it seems) can see. Might need to see how you're calling it and what's being passed in, & how you're using what's being passed back. But if you don't mind some nitpicking:
sub find_holes {
  # No need to dereference and create
  # a whole new array
  my $aref = shift;
  # This would probably be quicker w/a for loop and
  # just saving the max & min, but what the hay...
  my ($low, $high) = (sort { $a <=> $b } @$aref)[0,-1];
  my %isthere;
  # Hash slices are quicker
  @isthere{$low..$high} = ();
  @isthere{@$aref} = ("yes") x @$aref;
  # Grep first, sort last (fewer things to sort that way)
  # (and you sorted numerically before, why not now?)
  return [
    sort { $a <=> $b }
    grep { !$isthere{$_} } keys %isthere
  ];
}

[download]

In reply to Re: Finding missing elements in a sequence (code) by runrig
in thread Finding missing elements in a sequence (code) by deprecated

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.