If you know that $allocated_to will never contain "0" (a zero), then you can simplify the code to :

if ($allocated_to) {
  push @where_clause, "UPPER(ALLOCATED_TO) LIKE UPPER('%$allocated_to%
+')";
  push @entries, 'ALLOCATED_TO';
}

[download]

(the % don't need to be escaped in Perl strings) - possibly you might want to collapse both cases into a third subroutine like the following :

sub add_if_defined {
  my ($columnname,$queryvar) = @_;

  die "add_if_defined: First parameter (columnname) may not be empty (
+maybe you supplied columnname and queryvar in the wrong order ?)" 
    unless $columnname;

  if (defined($queryvar) && $queryvar ne '') {
   push @where_clause,"UPPER($columname) LIKE UPPER('%$queryvar%')";
   push @entries, $columnname;
  }
};

[download]
and then call that routine like follows : 
  add_if_defined("ALLOCATED_TO",$allocated_to);
  add_if_defined("CONTACT_PERSON",$contact_person);

[download]

This might make your code more readable, but it will also hide the actual side effects in the subroutine.

perl -MHTTP::Daemon -MHTTP::Response -MLWP::Simple -e ' ;    # The  
$d = new HTTP::Daemon and fork and getprint $d->url and exit;#spider
($c = $d->accept())->get_request(); $c->send_response( new   #in the
HTTP::Response(200,$_,$_,qq(Just another Perl hacker\n))); ' #  web

[download]

In reply to Re: Cleanup time by Corion
in thread Cleanup time by maderman

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.