The main problem I see here is carving a regexp that will reliably catch dates. The rest looks OK.

For fun here is how I would write it with... XML::Twig (surprise surprise! ;--). Note that it is quite easier to mark the first think to mark (dates here) than the following ones. I should probably add an option to ignore some tags (John M Dlugosz suggested this). Also if you want to use XML::DOM you can use XML::DOM::Twig, which implements a lot of XML::Twig methods over XML::DOM, and just cut'n paste the mark method from XML::Twig.

#!/bin/perl -w use strict; use XML::Twig; # create the regexp for date, this should be improved my $month = qr/(?:(?:Jan|Feb|Mar|Apr|May|Jun|Jul|Aug|Sep|Oct|Nov|Dec)\ +.?)/; my $day = qr/(?:(?:[0-2]?[0-9]|30|31)(?:st|nd|th)?)/; my $year = qr/(?:,?\s*\d+)?/; my $date= qr/($month $day$year)/; # this could probably be improved too! my $number= qr/(\d{2,})/; while( <DATA>) { chomp; # create the un-tagged XML my $t= XML::Twig->new(); # XML::Parser::Expat:::xml_escape just replaces & by &amp;, # > by &lt; etc... $t->parse( "<mytxt>". XML::Parser::Expat:::xml_escape( 1, $_) +. "</mytxt>"); # mark the dates $t->root->mark( $date, 'date'); # mark the numbers, foreach my $elt ($t->descendants( '#PCDATA')) { #skip if in date next if( $elt->in_context( 'date')); $elt->mark( $number, 'number'); } # output $t->print; print "\n"; } __DATA__ On Oct. 21, the Dow Jones rose to 10043 points On May 1st 2001, 12 people were working in France

Update: cacharbe is right, the text is probably not "XML-safe", so I added the XML escape when parsing $_.


In reply to Re: Building an XML File from text by mirod
in thread Building an XML File from text by pike

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.