I've been thinking about this as well, and still have more to do. I'll probably update this, but here's one thought for now.

"Using modules where appropriate" is one thing, but it can be taken too far. A lot of these programs are designed to be installed on rather broken Perl installations. That is, good luck trying to get Date::Manip installed. Or Perl 5.5.3. When they finally get 5.8, they'll realize that our fearless Borg pumpking has assimilated many useful things, but that could be another several years.

I'd dock points for reinventing wheels provided by the language or in the core library of reasonably recent versions (5.4 is reasonable). qx(date) is one thing, but I've seen programs that write files and then shell out to system grep several times.

Color me sympathetic to the people stuck on systems adminstered by the slightly-less-than legitimate operator from heck (incompetent, not evil), but I have very little mercy for people who think they write code worth sharing without even having skimmed perlfunc.

In reply to Re: Code review on script site by chromatic
in thread Code review on script site by Jazz

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.