I'm a bit leery of the "marking guide" checklist approach you've suggested: it strikes me as unnecessarily inflexible. The commenting thing is a good example: it started off as a reasonable guideline ("-1 for too few comments, +1 for many comments, etc"), but it's certainly plausible that "too few" comments might be just right (if the code is elegantly written and short enough to grasp easily, for instance). So the "must comment" rule got modified to something a bit more vague: "effective use of comments". The same thing happened with modules: "use CGI.pm" went to "use applicable core modules appropriately".

Giving points based on a definite scheme is sometimes appropriate for assignments in a course, where you have to quantify how well students do in order to give them a final mark (and credits), but here I don't really think it's a good fit. Instead, you might use a checklist like this as a guideline for code reviews, but give a more subjective rating (as well as a small list of pros and cons).

--
:wq

In reply to Re: Code review on script site by FoxtrotUniform
in thread Code review on script site by Jazz

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.